7612 - fix(ingest): No more JNDI lookup fails during deploy

[poikilotherm]

What this PR does / why we need it:
As we produce the JMS topic and factory for Ingest in
IngestQueueProducer since Dataverse 5.3, error messages
about unsupported missing message-destination appeared.
This commit fixes the underlying cause by using lookup()
instead of name() for the @resource dependency injection.

Which issue(s) this PR closes:

Closes #7612

Special notes for your reviewer:
Needs manual testing of Ingest!

Suggestions on how to test this:
Usual setup. Try real ingest, so the JMS part is actually used. Not sure API tests already cover that.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
None.

Is there a release notes update needed for this change?:
Nope.

Additional documentation:
None.

[pdurbin]

All the tests look fine at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-7613/4/testReport/ and I'm sure some ingest happens as part of them, so I'm pretty sure we can move this to QA. I didn't run the code to see if the offending line is gone from server.log.

I looked at the eehelp link and poked around a bit in javadoc and stackoverflow. I was hoping for more clear guidance on when "name" vs. "lookup" should be used. If we want, we could always add a line about this in our coding style page in the dev guide.

I noticed that @Resource(name = "mail/notifyMailSession") ("name" instead of "lookup") is still found in MailServiceBean. @poikilotherm do you think we should change this now (in this pull request) or later?

[poikilotherm]

I looked at the eehelp link and poked around a bit in javadoc and stackoverflow. I was hoping for more clear guidance on when "name" vs. "lookup" should be used. If we want, we could always add a line about this in our coding style page in the dev guide.

I wasn't able to find a good explanation in plain english. It's all a bit vague why we cannot use the name if we provide the resource via annotations.

I noticed that @Resource(name = "mail/notifyMailSession") ("name" instead of "lookup") is still found in MailServiceBean. @poikilotherm do you think we should change this now (in this pull request) or later?

Certainly. May be done as part of #7424

[pdurbin]

@poikilotherm good idea to defer the mail server work until that other issue.

Off to QA.