3175 edit dvpage bug #7628
3175 edit dvpage bug #7628
Conversation
sekmiller
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
src/main/webapp/dataverse.xhtml
Outdated
| <p:selectOneRadio id="OptionsRadio#{dsft.id}" value="#{dsft.requiredDV}" widgetVar="OptButton#{dsft.id}" disabled ="#{DataversePage.editInputLevel == false}" | ||
| rendered="#{!dsft.hasChildren and !((!dsft.hasChildren and dsft.required) or (dsft.hasChildren and dsft.hasRequiredChildren))}"> | ||
| <p:selectOneRadio id="OptionsRadio#{dsft.id}" value="#{dsft.requiredDV}" widgetVar="OptButton#{dsft.id}" disabled ="#{DataversePage.editInputLevel == false}" | ||
| onclick="#{DataversePage.toggleInputLevel(mdb.id, dsft.id)}" |
There was a problem hiding this comment.
what is this onclick doing? onclick is for calling javascript, but what you have here is a backing bean (java) call, so I don't think this would be called each time you click?
There was a problem hiding this comment.
I put it in because in my pre-testing I thought I had seen a case where changes to required/optional weren't being saved and because the method in the backing bean wasn't being used anywhere. I thought they were related so I put in the onclick. After removing both it seems to work so I'll chalk it up to bad pre-testing.
| @@ -287,6 +287,7 @@ | |||
| <p:ajax update="@widgetVar(optionBlock)" /> | |||
| </input> | |||
| <input type="checkbox" jsf:itemValue="#{mdb}" id="#{mdb.idString}" jsf:value="#{mdb.selected}" | |||
| jsf:disabled="#{DataversePage.editInputLevel == true}" | |||
There was a problem hiding this comment.
Does this still work without the jsf: passthrough? I would imagine it would. The other sibling basic HTML input's above it do not have it on their disabled attributes.
There was a problem hiding this comment.
It doesn't work without the jsf: because if the disabled tag is there even if it contains "false" it disables the component. The others on lines 284 and 286 have disabled="disabled" and the real decision work is done on the jsf:rendered.
| @@ -511,18 +511,6 @@ public void hideDatasetFieldTypes(Long mdbId) { | |||
| } | |||
| setEditInputLevel(false); | |||
| } | |||
|
|
|||
| public void toggleInputLevel( Long mdbId, long dsftId){ | |||
There was a problem hiding this comment.
Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)
There was a problem hiding this comment.
That was what was being called in the (now removed) onclick on the option buttons and nowhere else.
What this PR does / why we need it:
On create DV if the user went into custom metadata blocks before filling in the required "alias" and "category" fields the "Done" button to close the metadata block view wouldn't work. (also there was no indication why 'hey dummy, put in an alias for your new dv')
Also fixed an older bug where you could edit the input levels of an optional mdb and then deselect it.
Which issue(s) this PR closes:
Closes #3175
Closes #1198
Special notes for your reviewer:
@mheppler I used "jsf:disabled" for the 1198 fix. It seems to work but it's not used anywhere else. Kosher?
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: