Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7374 postgresql update #7651

Merged
merged 4 commits into from Mar 12, 2021
Merged

7374 postgresql update #7651

merged 4 commits into from Mar 12, 2021

Conversation

landreev
Copy link
Contributor

@landreev landreev commented Mar 4, 2021

What this PR does / why we need it:

PostgreSQL 9.6 is nearing its end of life (in Nov. 2021). This PR removes the language from the installation guide that specifies 9.6 as as the "strongly recommended" version, saying instead that the application has been tested with up to v. 13. It also tells the existing installations, via a release note, that it is ok to upgrade to a later version up to that.

Which issue(s) this PR closes:

Closes #7374

Special notes for your reviewer:

Suggestions on how to test this:

This is not a required upgrade. In this PR we are telling them to knock themselves out and upgrade to whatever they want, if they so desire. But they don't have to really.
A basic quick test is just to confirm that the application still functions under the latest Postgres (13.2 as of now).
I've tested upgrading and converting a copy of our prod db to later versions (that was the time-consuming part). I figured that if our database can be upgraded, then it should work for any other installation too.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the dev guide too.

@@ -98,25 +98,16 @@ PostgreSQL
Installing PostgreSQL
=======================

Version 9.6 is strongly recommended because it is the version developers and QA test with::
The application has been tested with PostgreSQL versions up to 13. We recommend installing the latest version that is available for your OS distribution. *For example*, to install PostgreSQL 13 under RHEL/CentOS 7::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the dev guide too. Right now it starts with, "PostgreSQL 9.6 is recommended to match the version in the Installation Guide."

I also think we should update Vagrant and docker-aio but especially since the Solr pull request touches both and hasn't been merged, it makes sense to wait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll definitely update the dev. guide, thanks.
Still not sure about touching the vagrant and docker-aio in this PR. I'd rather have somebody who uses/works on those extensively handle that. And I don't see a problem with doing that separately/later. I mean, everything there is going to keep working just fine with PG 9.6; touching/changing anything there on the other hand comes with the risk of breaking something in that fragile ecosystem.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue was created for vagrant and docker: #7660.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Mar 5, 2021
@kcondon kcondon self-assigned this Mar 12, 2021
@kcondon kcondon merged commit e678845 into develop Mar 12, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Mar 12, 2021
@kcondon kcondon deleted the 7374-postgresql-update branch March 12, 2021 20:29
@djbrooke djbrooke added this to the 5.4 milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Upgrade to PostgreSQL 13+
5 participants