Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor accessibility improvements to the user guides #7777

Merged
merged 3 commits into from Apr 14, 2021

Conversation

kaitlinnewson
Copy link
Contributor

What this PR does / why we need it:

Makes a few small accessibility improvements to the user guides, including:

  • fixing the heading levels on the guides landing page
  • setting the language for the guides
  • adding an aria label to the guides search input

Suggestions on how to test this:

Build the sphinx guides and confirm that:

  • the language is set in the <html> element
  • there is only one H1 on the landing page of the guides, and the headings below are set as H2
  • the search input has an aria-label set

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No interface changes

Is there a release notes update needed for this change?:

No

Additional documentation:

Screenshot of a WAVE test of the guides landing page in version 5.3:

Screen Shot 2021-04-08 at 1 56 44 PM

@TaniaSchlatter
Copy link
Member

Thank you, @kaitlinnewson!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Apr 13, 2021
@kcondon kcondon self-assigned this Apr 14, 2021
@kcondon kcondon merged commit 19e64c3 into IQSS:develop Apr 14, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Apr 14, 2021
@djbrooke djbrooke added this to the 5.5 milestone Apr 27, 2021
@kaitlinnewson kaitlinnewson deleted the guides-a11y branch November 8, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants