Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geospatial coverage "Other" field facetable #7813

Merged

Conversation

jggautier
Copy link
Contributor

What this PR does / why we need it:
This PR lets Dataverse admins add a search facet on their collection pages for the Geospatial metadatablock's "Other" field, so that others can narrow searches in their collections using the values entered in that "Other" field.

Which issue(s) this PR closes:

Closes #7399

Special notes for your reviewer:

Suggestions on how to test this:

  • Edit a Dataverse collection (Edit > General Information) to enable the Geospatial metadatablock (in the Metadata Fields section) and in the in the Browse/Search Facets section, add the Geospatial metadatablock's "Other" field as a facet.
  • Create a dataset with a value entered in the Geospatial metadatablock's "Other" field, save the dataset, and check if the Dataverse collection's page has an "Other" facet with a link for the value you entered in the Other field.
  • Click on that facet link and the page should show the dataset you created.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, this PR introduces a UI change. Mockups not available.

Is there a release notes update needed for this change?:

Yes.

Additional documentation:

@djbrooke
Copy link
Contributor

djbrooke commented Apr 21, 2021

Go @jggautier !!

For a release note, do you want to base the content on what we did for the Biomedical block update in 5.1? https://github.com/IQSS/dataverse/releases/tag/v5.1

(I'm happy to do this step as well if you'd like)

Also, there's a test failing, but I'm not sure if it's related.

@jggautier
Copy link
Contributor Author

Thanks, yeah, that makes sense to me. Something like this?:

Geospatial Metadata Block Updated
The Geospatial metadata block (geospatial.tsv) was updated. Dataverse collection administrators can now add a search facet on their collection pages for the metadata block's "Other" field, so that people searching in their collections can narrow searches using the values entered in that field.

Do installation admins need to follow the same steps in 5.1's "Additional Upgrade Steps" section?

@djbrooke
Copy link
Contributor

@jggautier - yeah, I think you've got it. Once you make that change the tests should run again, and we'll see if they pass (which I hope they should!)

@jggautier
Copy link
Contributor Author

Once I make a change to the release notes?

@djbrooke djbrooke moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 27, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Apr 27, 2021
@kcondon kcondon self-assigned this Apr 28, 2021
@kcondon
Copy link
Contributor

kcondon commented Apr 28, 2021

@jggautier This did not work for me. I reloaded the tsv file and then followed your steps but no facet appeared.

@jggautier
Copy link
Contributor Author

Thanks. Hmmm, did you or is it necessary to also do the steps described in the "Additional Upgrade Steps" section at the bottom of 5.1's release notes?:

I didn't include those steps in the release notes I draft for this PR because I wasn't sure if those steps needed to be followed for this change.

@kcondon
Copy link
Contributor

kcondon commented Apr 28, 2021

I did both, checking for facet between times.

@jggautier
Copy link
Contributor Author

Yikes, okay thanks. Should I open an issue about investigating why it doesn't seem possible to make this field facetable?

@kcondon
Copy link
Contributor

kcondon commented Apr 28, 2021

Or we could just put this pr back into dev, saying it is not working and put it up for investigation

@kcondon kcondon moved this from QA 🔎✅ to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 28, 2021
@kcondon kcondon removed their assignment Apr 28, 2021
@kcondon kcondon changed the title Make geospatial coverage "Other" field facetable Fix -Make geospatial coverage "Other" field facetable, tsv isn't making it facetable Apr 28, 2021
@kcondon kcondon changed the title Fix -Make geospatial coverage "Other" field facetable, tsv isn't making it facetable Make geospatial coverage "Other" field facetable Apr 28, 2021
@kcondon
Copy link
Contributor

kcondon commented Apr 28, 2021

@jggautier OK, was user error -I followed the first part of the bulletpoint, adding geospatial block but not the second part, adding the newly appearing facet option: Edit a Dataverse collection (Edit > General Information) to enable the Geospatial metadatablock (in the Metadata Fields section) and in the in the Browse/Search Facets section, add the Geospatial metadatablock's "Other" field as a facet.

@kcondon kcondon moved this from IQSS Team - In Progress 💻 to QA 🔎✅ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 28, 2021
@kcondon kcondon self-assigned this Apr 28, 2021
@kcondon kcondon merged commit 4a30c1d into develop Apr 28, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Apr 28, 2021
@kcondon kcondon deleted the 7399-make-geospatial-coverage-"Other"-field-facetable branch April 28, 2021 19:48
@jggautier
Copy link
Contributor Author

Ah okay. Probably less user error and more my poorly designed list of steps. :)

@kcondon
Copy link
Contributor

kcondon commented Apr 28, 2021

Well, I often read things quickly so mea culpa

@djbrooke djbrooke added this to the 5.5 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

"other" as facet in the geospatial metadata
3 participants