initial commit for Primefaces 10 - minimal modification to LazyFileMe… #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadataDataModel to work around breaking changes to Primefaces LazyDataModel
scolapasta
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
…hange in the latest version of PrimeFaces. The class was not being used in the code and it was decided to remove it after talking to Steve and Gustavo. There was also an instance declared in the DatasetPage, but again it was not serving any function
|
As per discussion with Steve and Gustavo, LazyFileMetadataDataModel has been removed completely |
scolapasta
approved these changes
Jun 7, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Jun 7, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tadataDataModel to work around breaking changes to Primefaces LazyDataModel
What this PR does / why we need it: Security improvements and base for implementing new features in the future
Which issue(s) this PR closes:#7726 Upgrade to Primefaces 10
Closes #7726
Special notes for your reviewer: The purpose of this change is simply to upgrade to Primefaces 10 to get security updates and to have a base for future enhancements using new features that Primefaces 10 provides. This PR does not implement any new features. The only code change made was a minimal one to work around breaking changes to Primefaces LazyDataModel. The change removes LazyFileMetadataModelDataModel's dependency on LazyDataModel (extends LazyDataModel), in order to successfully compile. By code inspection, I concluded that the code is currently dead code, but the function that it serves may still be implemented in the future, so it was not removed completely. Per discussion with Gustavo, I made these minimal changes, so that the effect of Primefaces 10 on the rest of the existing application could be tested.
Suggestions on how to test this: The change should be transparent. Exercise the UI to determine that Primefaces 10 has not broken existing functions
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: