7767 unable to download large guestbooks #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
reviewed
Jun 8, 2021
| export SERVER_URL=https://demo.dataverse.org | ||
| export ID=root | ||
|
|
||
| curl -O -J -H X-Dataverse-key:$API_TOKEN $SERVER_URL/api/dataverses/$ID/guestbookResponses?guestbookId=1 |
There was a problem hiding this comment.
I would suggest adding a GUESTBOOK_ID variable to match the others.
| DataverseRequest req = createDataverseRequest(u); | ||
| if (permissionSvc.request(req) | ||
| .on(dv) | ||
| .has(Permission.EditDataverse)) { |
There was a problem hiding this comment.
Seeing this permission check here in the API makes me wondering if we should create a command for both the API and UI to use.
pdurbin
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
I'm happy with the doc fix and from talking to @sekmiller it sounds like refactoring into a command is something we can pick up later.
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Jun 8, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds an api for retrieving the guestbook responses for a dataverse. We need it because currently the only way to retrieve these responses is via the ui and with larger dataverses the download may not work properly.
Which issue(s) this PR closes:
Closes #7767 Unable to download certain guestbooks related to number of responses
Special notes for your reviewer: I split up the existing streaming method in the service bean in order to facilitate the api
Suggestions on how to test this: was tested under my local db which has nowhere near the number of records as prod.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: as new functionality, probably deserves a mention.
Additional documentation: