IQSS/8028 enable import with test dois #8033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrooke
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
I'm not sure what the original design rationale was. But having thought about it - this sounds like a legitimate use case/scenario. Maybe when somebody needs to be able to import datasets that are under their legacy authority? Or to absorb datasets from another installation (the "how do I merge two Dataverse installations" question we occasionally get). So this was most likely the reason for that GET attempt in the original code, instead of .alreadyExists(). We could ask - but I'm inclined to just approve the PR as is. |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Jul 29, 2021
kcondon
moved this from QA 🔎✅
to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
changed the title
…ort_with_test_DOIs
djbrooke
moved this from Review 🦁
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Allows use of DataCite test DOIs with the various import/migrate API calls
Which issue(s) this PR closes:
Closes #8028
Special notes for your reviewer: Does anyone know if the :import and :importddi API calls are intended to allow import of DOIs that don't have the right authority/shoulder to be managed by the Dataverse instance? If not, this PR could be simplified to just check, using credentials, whether the PID exists.
Suggestions on how to test this: Should be able to repeat the migrate tests with a test DOI now
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation:none