7771 accessibility update form labels #8042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
reviewed
Aug 5, 2021
src/main/webapp/dataverseuser.xhtml
Outdated
| @@ -571,7 +571,7 @@ | |||
| <div class="form-horizontal"> | |||
| <div class="form-group" jsf:rendered="#{DataverseUserPage.editMode == 'CREATE' or DataverseUserPage.editMode == 'EDIT'}"> | |||
| <!-- Username --> | |||
| <label for="userNameEmail" class="col-sm-3 control-label"> | |||
| <label for="dataverseUserForm:accountInfoView:userName" class="col-sm-3 control-label"> | |||
There was a problem hiding this comment.
@sekmiller rather than add the whole name (though dropping the mail was definitely needed), did you try using <h:outputLabel> or <p:outputLabel>? If that works, that would be better, in case the structure changes some day.
There was a problem hiding this comment.
I didn't try it originally because I wasn't sure if I could replicate the formatting. I'll see if I can get it to look right with outputLabel.
scolapasta
approved these changes
Aug 6, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Aug 6, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes the correlation between labels and inputs on the dataverse user page when in create mode.
Which issue(s) this PR closes:
Closes #7771 Accessibility form labels not associated with inputs on Sign Up Page
Special notes for your reviewer:
Suggestions on how to test this:
I installed the checking tool mentioned in the issue https://wave.webaim.org/
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
no
Additional documentation:
none