Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jquery 3.5.1 #8071

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Aug 20, 2021

What this PR does / why we need it: Per the issue, Primefaces 10 uses 3.5.1 by default, but having a 3.4.1 version in our source tree overrides that. So this PR removes it.

Which issue(s) this PR closes:

Closes #8068

Special notes for your reviewer:

Suggestions on how to test this: Look for the jquery files used in the webpage, e.g. looking in the browser dev console network tab, and open them in a separate window to verify that the version shown in the source is 3.5.1. The change could potentially break UI functionality (anywhere we or PrimeFaces uses jquery) but I'd expect 3.5.1 would if anything work better than having us override to 3.4.1 (since PrimeFaces ships with it.)

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no?

Additional documentation:

@donsizemore
Copy link
Contributor

Removing jquery.js per @qqmyers' instructions renders the following on the 5.6 release:

Screen Shot 2021-08-20 at 10 52 17

I can create a collection and dataset, but haven't tested much beyond that.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done any testing but this seems like a nice, easy fix, and simple to revert if we need to.

@donsizemore already commented that simply removing the 3.4.1 version from a server worked.

As of this writing, if you go to https://demo.dataverse.org/javax.faces.resource/jquery/jquery.js.xhtml?ln=primefaces&v=10.0.0 it will show "3.4.1". Once you remove the file, it shows the version Primefaces provides (3.5.1).

So it's all much more maintainable.

The last thing I'll mention is that in pull request #6079 both Bootstrap and jQuery were updated to an identical version (3.4.1). I know we want to upgrade to Bootstrap 4 in #6045 but meanwhile I don't know if it's crucial to keep Bootstrap and jQuery versions in sync.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Aug 20, 2021
@kcondon kcondon self-assigned this Aug 23, 2021
@kcondon kcondon merged commit c26803e into IQSS:develop Aug 23, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Aug 23, 2021
@djbrooke djbrooke added this to the 5.7 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove local override of jQuery version, get version from Primefaces instead
5 participants