Update citation.properties #8072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Aug 24, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per the issue, it looks like new authorIdentifierSchemes were added to the citation metadata block/tsv file a couple years ago but the corresponding entries weren't added to citation.properties (where default values come from if you set a language dir for i18n. The problem was only discovered recently when I added a warning message in the log - the failure to find them was silent before.
Which issue(s) this PR closes:
Closes #8065
Special notes for your reviewer: Since the code defaults to using the values in the tsv file when they don't exist in a properties file, the main impact has been the silent failures and now warning log messages. For people creating citation block property files in other languages for i18n, these three entries were missing (again fairly minimal impact with the default values appearing and perhaps no need to translate these values anyway?)
Suggestions on how to test this: Warnings should disappear, changes to the display values in citation.properties should show in the UI.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: ~no
Is there a release notes update needed for this change?:
Additional documentation: