show breadcrumbs for direct child of root datasets #7257 #8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Aug 25, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Dataverse 4, we always showed breadcrumbs for datasets in root. As part of the Dataverse 5 redesign (in pull request #6909 for #6684), we hid breadcrumbs for datasets in root. This pull request reverts that commit (95d7e04), restoring the behavior back to how it was.
Which issue(s) this PR closes:
Closes #7257
Special notes for your reviewer:
The commit above that changed the behavior between 4 and 5 is mentioned above.
Suggestions on how to test this:
Create datasets in root and non-root collections. Observe that the breadcrumbs are present in both cases.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, here's a dataset in the root collection with breadcrumbs.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
None.