Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geospatial.tsv #8081

Merged
merged 1 commit into from Aug 31, 2021
Merged

Update geospatial.tsv #8081

merged 1 commit into from Aug 31, 2021

Conversation

inDane
Copy link
Contributor

@inDane inDane commented Aug 31, 2021

What this PR does / why we need it:
cosmetic; it gets rendered correctly on github.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:
it shouldn't change anything but a correct rendering on github...

Suggestions on how to test this:
Upload new file to dataverse.
curl http://localhost:8080/api/admin/datasetfield/load -H "Content-type: text/tab-separated-values" -X POST --upload-file geospatial.tsv

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no

Is there a release notes update needed for this change?:
no

Additional documentation:

@djbrooke
Copy link
Contributor

Thanks @inDane for the PR. Just to confirm, under the "Suggestions on how to test this" section, the suggestion is to do a regression testing and also look in GitHub to confirm that the display is correct? If so, this makes sense, and thanks again!

@inDane
Copy link
Contributor Author

inDane commented Aug 31, 2021

@djbrooke yes, with
curl http://localhost:8080/api/admin/datasetfield/load -H "Content-type: text/tab-separated-values" -X POST --upload-file geospatial.tsv
I tested if I broke anything...

See here to check the correct rendering.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing "Whitespace-only changes" is a good sign:

Screen Shot 2021-08-31 at 11 24 21 AM

It's nice when these TSVs render properly on GitHub. Thanks for the pull request, @inDane

@djbrooke I didn't test this but it's probably safe to move to QA if you want to go ahead.

@djbrooke
Copy link
Contributor

@pdurbin thanks, feel free to approve if it looks OK to you!

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Aug 31, 2021
@kcondon kcondon self-assigned this Aug 31, 2021
@kcondon kcondon merged commit 2225313 into IQSS:develop Aug 31, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Aug 31, 2021
@djbrooke djbrooke added this to the 5.7 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants