add fixmissingoriginalsizes API call to 5.0 upgrade prerequisites #8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrooke
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
@donsizemore - I changed "latest" to 5.0 in fa40358 - what do you think? |
djbrooke
approved these changes
Sep 29, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Sep 29, 2021
pdurbin
reviewed
Sep 29, 2021
There was a problem hiding this comment.
Overall, this looks good. I left a couple niggling comments.
This could be a good opportunity to think more about this issue I opened:
- Process for updating release notes after a release Process for updating release notes after a release #7988
In short, what's the process for keeping the version in git in sync with the live version?
|
|
||
| To check your installation, issue this command: | ||
|
|
||
| `curl https://localhost/api/admin/datafiles/integrity/fixmissingoriginalsizes` |
There was a problem hiding this comment.
Hmm, https with no port on localhost seems weird. Maybe just http (no s) and port 8080?
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The fixmissingoriginalsizes API step was optional in version 4.n, but required for 5.0, and not mentioned in the release notes. This has tripped up a number of installations as they upgrade.
Which issue(s) this PR closes:
Closes #8123
Special notes for your reviewer: none
Suggestions on how to test this: compare against existing documentation
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: yes
Additional documentation: none