8266 fix handle command click #8268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrooke
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
…o that only the terms of use and access are considered (and not the guestbook which should only be considered at file download in isDownloadPopupRequired).
sekmiller
approved these changes
Dec 3, 2021
sekmiller
moved this from Review 🦁
to QA 🔎✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes FileDownloadHelper.handleCommandLinkClick() method
Which issue(s) this PR closes:
Closes #8266
Special notes for your reviewer:
Suggestions on how to test this:
Create a dataset. No terms of use, no terms of access. Add guestbook.
Click 'Request Access' for a single file.
The Request Access will be submitted with no empty popup beforehand even though there is a guestbook.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None