8381 curation lables internationalization #8466
Conversation
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
| @@ -2517,6 +2517,12 @@ Each set of labels is identified by a curationLabelSet name and a JSON Array of | |||
|
|
|||
| ``curl -X PUT -d '{"Standard Process":["Author contacted", "Privacy Review", "Awaiting paper publication", "Final Approval"], "Alternate Process":["State 1","State 2","State 3"]}' http://localhost:8080/api/admin/settings/:AllowedCurationLabels`` | |||
|
|
|||
| If the Dataverse Installation supports multiple languages, the curation label translations should be added to the Bundle property files. | |||
There was a problem hiding this comment.
I'd recommend being explicit w.r.t. the rewrite rule - i.e. the entries have to be lower case and spaces replaced with _
There was a problem hiding this comment.
added additional notes
| @@ -1953,6 +1954,14 @@ public String getExternalStatusLabel() { | |||
| return externalStatusLabel; | |||
| } | |||
|
|
|||
| public String getLocaleExternalStatusLabel() { | |||
There was a problem hiding this comment.
minor point - could there be a util function instead of three ~near duplicate ones in different classes?
There was a problem hiding this comment.
Thanks @qqmyers , moved the function to DatasetUtil.java
There was a problem hiding this comment.
@JayanthyChengan thanks for the pull request!
I ran the code and it see to work fine (I put some values in Bundle.properties). I noticed a small .rst problem and left a comment about where to put the key/value pairs. Please take a look.
src/main/java/edu/harvard/iq/dataverse/dataset/DatasetUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
…s_internationalization
There was a problem hiding this comment.
Looks good, thanks for the pull request, @JayanthyChengan
@kcondon I only did minimal testing. I created a file at src/main/java/propertyFiles/CurationLabels.properties and put in some values I wanted to override (as explained in the doc update). I didn't try adding a French translation but I think the file would be called CurationLabels_fr.properties. In practice, installations won't be putting these files anywhere in the src directory. They'll put them (along with other properties files) in a "lang" directory: https://guides.dataverse.org/en/5.9/installation/config.html#configuring-the-lang-directory . Thanks my understanding anyway.
|
@JayanthyChengan now that we've released Dataverse 5.10 can you please update your branch from "develop"? Thanks. |
…s_internationalization
|
@pdurbin : merged develop branch . |
What this PR does / why we need it:
To display curation Labels in multiple languages.
Which issue(s) this PR closes:
Closes #8381
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: