8506 powered by footer #8507
Merged
8506 powered by footer #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
approved these changes
Mar 21, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Mar 21, 2022
|
Thank you for approving! I totally agree that there must be a better solution. I do not have the necessary background on css to improve it by myself, I have tried different options and this one works for me. |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Mar 23, 2022
|
@ErykKul just a heads up that we made a further tweak to this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Dataverse footer with "powered by dataverse" logo gets rendered at relative position iso absolute by default. This happens with overloaded custom footer with default style block and on pages that do not fit on screen. See the linked issue for more detail.
Which issue(s) this PR closes:
closes #8506