Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production date in citation for harvested dataset #8732

Merged
merged 5 commits into from
Oct 12, 2022

Conversation

tcoupin
Copy link
Member

@tcoupin tcoupin commented May 24, 2022

What this PR does / why we need it:

Date in citation div is the "citation date" which is most of th time the publication date (the first release date) (https://guides.dataverse.org/en/latest/api/native-api.html?highlight=citationdate#set-citation-date-field-type-for-a-dataset).

But for a harvested dataset, the distribution date is used instead and this date is not always present. With oai_dc format the date tag if used as production date (when harvesting (see code) AND serving (see code)).

This PR try to use production date for harvested dataset in addition to distribution date

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin
Copy link
Member

pdurbin commented May 24, 2022

@tcoupin from a very quick look I think we'll need some documentation. A small change to the guides would be great and lasting (more lasting than a release note). In addition, a release note fragment would be nice so we can highlight the change. Please see https://guides.dataverse.org/en/5.10.1/developers/making-releases.html#write-release-notes

@tcoupin
Copy link
Member Author

tcoupin commented May 30, 2022

Hi @pdurbin
Release note added.
But I don't found any section in the guide about citation building to update. The PR affects only the citation generation.

@pdurbin
Copy link
Member

pdurbin commented Jun 2, 2022

@tcoupin thanks, you're probably right about the guides.

I hope you don't mind but I'm using your PR to trigger a build on our Jenkins server. 😄

@pdurbin pdurbin mentioned this pull request Jun 2, 2022
@scolapasta scolapasta moved this from On Deck 🛎 to Next Sprint 🏃‍♀️ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jul 20, 2022
@gwendoux gwendoux added this to Interested in Cirad Dataverse Jul 28, 2022
@scolapasta
Copy link
Contributor

Hi @tcoupin, for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks!

@tcoupin tcoupin force-pushed the tc-citationdate-harvested-dataset branch from 2fff024 to ddbd3e5 Compare August 4, 2022 20:12
@tcoupin
Copy link
Member Author

tcoupin commented Aug 4, 2022

I rebase on develop branch

@sekmiller sekmiller assigned sekmiller and unassigned sekmiller Sep 6, 2022
@sekmiller sekmiller moved this from This Sprint 🏃‍♀️ to Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Sep 6, 2022
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the contribution. And @tcoupin, please once again update this branch with the latest from develop. Thanks!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🔎 to QA ✅ Sep 12, 2022
@sekmiller sekmiller removed their assignment Sep 12, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 20.032% when pulling 6a2ec03 on tcoupin:tc-citationdate-harvested-dataset into c7b8b82 on IQSS:develop.

@sekmiller sekmiller self-assigned this Oct 5, 2022
@sekmiller sekmiller merged commit f6c677b into IQSS:develop Oct 12, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 12, 2022
@pdurbin pdurbin added this to the 5.13 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Year in citations of harvested datasets is always current year
5 participants