Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset Archiving: BagIt bag-info.txt has some fields that are populated from bundle.properties, could be doc'd and maybe made a setting? #8760

Closed
kcondon opened this issue Jun 1, 2022 · 3 comments · Fixed by #10122
Closed

Dataset Archiving: BagIt bag-info.txt has some fields that are populated from bundle.properties, could be doc'd and maybe made a setting? #8760

kcondon opened this issue Jun 1, 2022 · 3 comments · Fixed by #10122
Labels
NIH OTA 2.4.2 Improve Dataverse BagIt-based archiving support pm.GREI-d-2.4.2 2.4.2 Improve Dataverse BagIt-based archiving support Size: 3 A percentage of a sprint. 2.1 hours.
Milestone
6.1

Comments

@kcondon
Copy link
Contributor

kcondon commented Jun 1, 2022

While testing a recent bag-it, dataset archiving change, noticed the bag-info.txt file had some filler, replacement text in it. In discussing with @qqmyers it was identified as an earlier attempt at populating the fields and that they could be populated in a more standardized and documented way:

cat bag-info.txt
Contact-Name: kc052622b, kc052622b
Contact-Email: kc052622b@mailinator.com
Source-Organization: Dataverse Installation ()
Organization-Address:
Organization-Email:
External-Description: This is my description
Bagging-Date: 2022-05-26
External-Identifier: doi:10.70122/FK2/DJNPSO
Bag-Size: 109.77 KB
Payload-Oxum: 109765.3
Internal-Sender-Identifier: Dataverse Internal:kc052622b

from @qqmyers:

they ~are filled in, with the values from

dataverse/src/main/java/propertyFiles/Bundle.properties

Lines 2269 to 2271 in 552dfc8

bagit.sourceOrganization=Dataverse Installation (<Site Url>)
bagit.sourceOrganizationAddress=<Full address>
bagit.sourceOrganizationEmail=<Email address>

if you want an issue to move these things, or document that they exist (not sure if they are in the guides or not), feel free to add one and I'll take a look.
Bundle.properties
bagit.sourceOrganization=Dataverse Installation ()
bagit.sourceOrganizationAddress=
bagit.sourceOrganizationEmail=
@qqmyers qqmyers mentioned this issue Jun 23, 2022
Open
@cmbz cmbz added pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues pm.GREI-d-2.4.2 2.4.2 Improve Dataverse BagIt-based archiving support NIH OTA 2.4.2 Improve Dataverse BagIt-based archiving support and removed pm.GREI-d-2.4.1B NIH AIM:4 YR:2 TASK:1B | 2.4.1B | (started yr1) Resolve OAI-PMH harvesting issues labels Aug 28, 2023
@cmbz cmbz added this to the 6.1 milestone Sep 25, 2023
@cmbz
Copy link

cmbz commented Sep 25, 2023

2023/09/25: Added to 6.1 milestone as per conversation during prioritization meeting.

@cmbz
Copy link

cmbz commented Oct 23, 2023

2023/10/23: Sized at: 3 during resizing meeting.

@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 23, 2023
@pdurbin pdurbin moved this from ▶ SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 8, 2023
@pdurbin pdurbin moved this from This Sprint 🏃‍♀️ 🏃 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 13, 2023
@pdurbin pdurbin self-assigned this Nov 13, 2023
@pdurbin
Copy link
Member

pdurbin commented Nov 14, 2023

Judging from https://jenkins.dataverse.org/job/IQSS-dataverse-develop/ws/target/coverage-it/edu.harvard.iq.dataverse.util.bagit/BagGenerator.java.html this code should be covered by tests:

Screenshot 2023-11-14 at 11 41 45 AM

pdurbin added a commit that referenced this issue Nov 15, 2023
@pdurbin
assert current /bag-info.txt behavior #8760
5bfb6b8 
Also, add a superuser-only API for downloading files
(such as bags) from the file system so we can make
assertions about them in our tests.
@pdurbin pdurbin changed the title Dataset Archiving: Bag it bag-info.txt has some fields that are populated from bundle.properties, could be doc'd and maybe made a setting? Dataset Archiving: BagIt bag-info.txt has some fields that are populated from bundle.properties, could be doc'd and maybe made a setting? Nov 15, 2023
pdurbin added a commit that referenced this issue Nov 15, 2023
@pdurbin
configurable BagIt source org name, address, email #8760
22a1d0d 
These values were used while testing:

DATAVERSE_BAGIT_SOURCEORG_NAME=LibraScholar
DATAVERSE_BAGIT_SOURCEORG_ADDRESS=123 Wisdom Way\nCambridge, MA\nUSA
DATAVERSE_BAGIT_SOURCEORG_EMAIL=hello@dataverse.librascholar.edu
@pdurbin pdurbin mentioned this issue Nov 15, 2023
Merged
@pdurbin pdurbin removed their assignment Nov 15, 2023
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
assert current /bag-info.txt behavior #8760
874e9fc 
Also, add a superuser-only API for downloading files
(such as bags) from the file system so we can make
assertions about them in our tests.
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
configurable BagIt source org name, address, email #8760
2cc747e 
These values were used while testing:

DATAVERSE_BAGIT_SOURCEORG_NAME=LibraScholar
DATAVERSE_BAGIT_SOURCEORG_ADDRESS=123 Wisdom Way\nCambridge, MA\nUSA
DATAVERSE_BAGIT_SOURCEORG_EMAIL=hello@dataverse.librascholar.edu
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
add docs and release note for bag-info.txt config #8760
f0f5ac7
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
assert current /bag-info.txt behavior #8760
2500bcc 
Also, add a superuser-only API for downloading files
(such as bags) from the file system so we can make
assertions about them in our tests.
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
configurable BagIt source org name, address, email #8760
7240e87 
These values were used while testing:

DATAVERSE_BAGIT_SOURCEORG_NAME=LibraScholar
DATAVERSE_BAGIT_SOURCEORG_ADDRESS=123 Wisdom Way\nCambridge, MA\nUSA
DATAVERSE_BAGIT_SOURCEORG_EMAIL=hello@dataverse.librascholar.edu
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
add docs and release note for bag-info.txt config #8760
b2c6251
pdurbin added a commit that referenced this issue Nov 17, 2023
@pdurbin
limit to downloading from /tmp, add docs #8760
fa6f850
pdurbin added a commit that referenced this issue Dec 5, 2023
@pdurbin
Merge branch 'develop' into 8760-bagit #8760
96c7066 
Conflicts:
doc/sphinx-guides/source/api/changelog.rst
pdurbin added a commit that referenced this issue Dec 5, 2023
@pdurbin
Merge branch 'develop' into 8760-bagit #8760
db913ca 
Conflicts:
src/main/java/edu/harvard/iq/dataverse/settings/JvmSettings.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NIH OTA 2.4.2 Improve Dataverse BagIt-based archiving support pm.GREI-d-2.4.2 2.4.2 Improve Dataverse BagIt-based archiving support Size: 3 A percentage of a sprint. 2.1 hours.
Projects
IQSS Dataverse Project
Status: No status
Milestone
6.1
Development

Successfully merging a pull request may close this issue.

make BagIT source organization info (name, address, email) configurable IQSS/dataverse
3 participants
@pdurbin @kcondon @cmbz