IQSS/8957 JWT creation test for DRS Archiver #8958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/main/java/edu/harvard/iq/dataverse/engine/command/impl/LocalSubmitToArchiveCommand.java
or create ones to compare with our local one. I'l probably add this back in the DRS archiver where we'll have other means to send the hashes.
probably not required - good practice/helped in debugging to be able to check sourcecode online which is for the current version.
note that the write to file part of the bag generation already tests the hash values of the individual files internally.
there are archived copies, or one can archive this dataset
(same signature as Dataset in 3b - inherit?)
GDCC/8914-COAR-compliant_messaging
qqmyers
added this to On Deck 🛎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
requested changes
Sep 7, 2022
|
Doesn't https://github.com/IQSS/dataverse/runs/8216433360?check_suite_focus=true#step:5:1132 show it ran and didn't fail? |
|
@pdurbin - I don't see any reason it should fail only in jenkins - can a new run be triggered to see if this is repeatable? |
GDCC/9016-handle-no-file-PID-case-in-metrics
|
This is a small amount of code - a test that should pass. It was accidentally left out of earlier PRs. Shouldn't take much review or QA. Size 3 |
scolapasta
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
approved these changes
Feb 1, 2023
scolapasta
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Just a simple test created for HDC 3A / Archiving to DRS that didn't make it into the main PR.
Which issue(s) this PR closes:
Closes #8957
Special notes for your reviewer:
Suggestions on how to test this: Verify the test runs and doesn't fail in the auto build.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: