Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDCC/Harvesting server it test failing #9026

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 5, 2022

What this PR does / why we need it: Possible repeat of #8937 - the testOaiFunctionality() test is still occasionally failing, as in #9001. After trying various experiments and discovering that Oai/this test rely on the metadata exports being created after publication, I made a modified copy of the UtilIT.sleepForReindex to sleepForReexport(). This call will wait up to the defined limit (in seconds) for metadata exports to be complete. From a number of test runs, it appears that doing this can avoid the error, and allows removal of a 5 second delay that was in prior code. The PR also adds a loop to retry the call to find the exported set in case there is a delay there. Lastly, a minor tweak was added to make sleepFor* take a maximum delay in seconds rather than a loop count.

Which issue(s) this PR closes:

Closes #8937

Special notes for your reviewer: Hopefully the sleepForReindex and possibly the sleepForReexport method can be reused elsewhere to avoid fixed delays. FWIW: In one run, I see Waited 2.5 seconds for export, the next was Waited 3.5 seconds for export. Given the original code waited 3 seconds here, it makes sense that it was an occasional issue.

Suggestions on how to test this: Assure the test passes in this PR. Not sure how to test whether it is better than the old code without deploying it to other branches, but given that the test works here, I'm not sure such additional testing is needed.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Oct 5, 2022

Coverage Status

Coverage increased (+0.001%) to 19.982% when pulling 23cc663 on GlobalDataverseCommunityConsortium:GDCC/HarvestingServerIT_test_failing into 11abccf on IQSS:develop.

@qqmyers qqmyers marked this pull request as ready for review October 19, 2022 13:01
@pdurbin pdurbin added this to Items Added To Board By Mistake in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Nov 30, 2022
@pdurbin pdurbin moved this from Items Added To Board By Mistake to QA ✅ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 30, 2022
@kcondon kcondon self-assigned this Nov 30, 2022
@kcondon kcondon merged commit 3541edd into IQSS:develop Nov 30, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Nov 30, 2022
@pdurbin pdurbin added this to the 5.13 milestone Dec 7, 2022
@mreekie
Copy link

mreekie commented Jan 9, 2023

Grooming:

  • Moved this to "been in sprint"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

test failure in develop: HarvestingServerIT.testOaiFunctionality
5 participants