Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8903 email subject #9056

Merged
merged 8 commits into from
Oct 28, 2022
Merged

8903 email subject #9056

merged 8 commits into from
Oct 28, 2022

Conversation

JayanthyChengan
Copy link
Contributor

What this PR does / why we need it:
Some of the notification emails received from the Dataverse system include the dataset name in the subject (e.g., dataset created), whereas others do not (e.g., dataset published).

So, including the dataset name for those missing in the subject line.

Which issue(s) this PR closes:
Closes #8903

@coveralls
Copy link

coveralls commented Oct 12, 2022

Coverage Status

Coverage increased (+0.004%) to 19.979% when pulling c93ac01 on scholarsportal:8903_emailSubject into cbc0e52 on IQSS:develop.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from On Deck 🛎 to QA ✅ Oct 26, 2022
@sekmiller sekmiller self-assigned this Oct 28, 2022
@sekmiller sekmiller merged commit 42e2b59 into IQSS:develop Oct 28, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 28, 2022
@pdurbin pdurbin added this to the 5.12.1 milestone Oct 28, 2022
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this pull request Nov 17, 2022
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this pull request Nov 17, 2022
qqmyers added a commit that referenced this pull request Nov 17, 2022
qqmyers added a commit that referenced this pull request Nov 17, 2022
This reverts commit 2ec5f23.
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this pull request Nov 17, 2022
@qqmyers qqmyers mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Missing dataset name in the email subject line
5 participants