Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDCC/commons-text update #9062

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 14, 2022

What this PR does / why we need it: Earlier versions of commons-text have functionality we don't use. In this version, it is off by default.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this: basic regression testing if anything

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 19.981% when pulling 0fb1bf0 on GlobalDataverseCommunityConsortium:GDCC/update-commons-text into da6db57 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from On Deck 🛎 to QA ✅ Oct 14, 2022
@pdurbin
Copy link
Member

pdurbin commented Oct 14, 2022

As of da6db57 (latest in develop), here's where this library is used (when I remove it temporarily):

GuestbookResponseServiceBean.java:[34,31] package org.apache.commons.text does not exist
Guestbook.java:[26,31] package org.apache.commons.text does not exist
DOIDataCiteRegisterService.java:[26,31] package org.apache.commons.text does not exist
util/bagit/BagGenerator.java:[48,31] package org.apache.commons.text does not exist
DataversePage.java:[52,31] package org.apache.commons.text does not exist
DatasetPage.java:[129,31] package org.apache.commons.text does not exist
EditDataFilesPageHelper.java:[5,31] package org.apache.commons.text does not exist
util/MarkupChecker.java:[8,31] package org.apache.commons.text does not exist
ManagePermissionsPage.java:[44,31] package org.apache.commons.text does not exist
workflows/WorkflowUtil.java:[22,38] package org.apache.commons.text does not exist
DataCitation.java:[37,31] package org.apache.commons.text does not exist
RolePermissionFragment.java:[39,31] package org.apache.commons.text does not exist

I took a quick look at the release notes at https://commons.apache.org/proper/commons-text/changes-report.html#a1.10.0

It's a minor release. I didn't see anything about breaking changes.

@sekmiller sekmiller merged commit 470f99b into IQSS:develop Oct 21, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 21, 2022
@pdurbin pdurbin added this to the 5.12.1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants