Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP URL to HTTPS URL #9068

Merged
merged 13 commits into from
Nov 1, 2023
Merged

Update HTTP URL to HTTPS URL #9068

merged 13 commits into from
Nov 1, 2023

Conversation

bencomp
Copy link
Contributor

@bencomp bencomp commented Oct 17, 2022

What this PR does / why we need it:
This updates (almost) all HTTP URLs found in the documentation and code to HTTPS. It increases privacy of readers and may even save some time if the HTTP address needs to redirect to the HTTPS address.

Which issue(s) this PR closes:

I found the HTTP URLs after looking at #9054, but this is unrelated.

Special notes for your reviewer:
I manually checked that the HTTPS URLs resolve. Some do redirect to updated URLs, but I only updated the URL if the content matched the expected content. There may be exceptions to this rule.

I couldn't access the Phoenix server, so I kept those URLs the same.

Suggestions on how to test this:
For now, you could scan the changes and perhaps sample a few URLs to see that resolve to what you would expect.
In the future, you could use an automatic link checker.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
It does change the template of the Guides, so changes may be recognised on many users.

Is there a release notes update needed for this change?:
N/A
Additional documentation:

@bencomp
Copy link
Contributor Author

bencomp commented Aug 23, 2023

Merge conflicts caused by #9616 efforts have been resolved.

@bencomp
Copy link
Contributor Author

bencomp commented Aug 23, 2023

Updated URLs in the "classic dev environment". Hoping for a positive review 🤞

@bencomp
Copy link
Contributor Author

bencomp commented Aug 24, 2023

Fixed merge conflict caused by merging #9796.

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight-forward http -> https cleanup.

@qqmyers qqmyers added the Size: 0.5 A percentage of a sprint. 0.35 hours label Oct 30, 2023
@qqmyers qqmyers added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Oct 30, 2023
@qqmyers qqmyers moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Oct 30, 2023
@landreev landreev merged commit e47e016 into IQSS:develop Nov 1, 2023
1 of 2 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Nov 1, 2023
@pdurbin pdurbin added this to the 6.1 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants