Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Solr docs #9071

Merged
merged 8 commits into from
Oct 27, 2022
Merged

Fixes in Solr docs #9071

merged 8 commits into from
Oct 27, 2022

Conversation

HenningTimm
Copy link
Contributor

@HenningTimm HenningTimm commented Oct 18, 2022

What this PR does / why we need it:
This PR introduces some minor fixes and (hopefully) improvements to the Solr documentation. Most notably it reframes a link to a resolved issue associated with Solr reindexing. While indexing is still a major endeavor, the previous wording sounded to me like the Issue was still in active development.
This PR keeps the important information in place (that reindexing takes some time). However, it changes the wording such that the link serves more as documentation than an issues that is actively worked on.

Further, this PR add some minor style fixes:

  • Consistency of Solr casing (Solr with a capital S seems to be the right version.)
  • Minor typographic fixes
  • Extend section on reindexing to explain what a "completely clean index" means

Is there a release notes update needed for this change?: No

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HenningTimm this all looks great. Thanks for the pull request!

I might quibble about whether or not destroying a dataset leaves stale entries in Solr but it's certainly possible. 😄

Merging! Thanks again!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🔎 to QA ✅ Oct 27, 2022
@pdurbin pdurbin merged commit c153337 into IQSS:develop Oct 27, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 27, 2022
@pdurbin pdurbin removed their assignment Oct 27, 2022
@pdurbin pdurbin added this to the 5.12.1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants