Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6071 - Update docs with information on setting dataverse.siteUrl JVM option #9072

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

j-n-c
Copy link
Contributor

@j-n-c j-n-c commented Oct 18, 2022

What this PR does / why we need it:

Documentation does not highlight the importance of setting dataverse.siteUrl JVM option

Which issue(s) this PR closes:

Closes #6071

Special notes for your reviewer:

Suggestions on how to test this:

Navigate to Installation guide > Installation > Installation > Troubleshoot > Got ERR_ADDRESS_UNREACHABLE while navigating on interface or API calls

Navigate to Installation guide > Configuration > JVM Options > dataverse.siteUrl

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin
Copy link
Member

pdurbin commented Oct 21, 2022

@pdurbin pdurbin self-assigned this Oct 27, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-n-c thanks for this pull request! I made some further tweaks.

Approved! Merging! Thanks again!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🔎 to QA ✅ Oct 27, 2022
@pdurbin pdurbin merged commit fdd2cab into IQSS:develop Oct 27, 2022
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Oct 27, 2022
@pdurbin pdurbin removed their assignment Oct 27, 2022
@pdurbin pdurbin added this to the 5.12.1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

system service URL formation does not take into account URL used for navigation
2 participants