Iqss/9183 terms of access validation fix

[haarli]

What this PR does / why we need it:
Prevents that an dataset is saved twice (which might result in subsequent OptimisticLockingError problems), when the two hidden input fields for Terms of Access validation are not available (e.g. due to a customized terms page)

Which issue(s) this PR closes:

Closes #9183

[qqmyers]

Interesting issue - fixing a bug that only appears in a fork. W.r.t. the code in the PR, it makes sense to move the code into the try block - it should have no effect for the community version but is reasonable code clean-up - if anything is changed here in the future such that another way to have an error is introduced, the current code could end up doing a double save, as in the fork, and the PR prevents that possibility.

[pdurbin]

@haarli can you please explain how to reproduce the problem? In the issue you said you removed some input fields? Which ones? Is there some other way to reproduce it?

[haarli]

As you already mentioned, this is a very special behaviour which only takes effect when you mess around with the dataset-license-terms page. So this PR is just a code cleanup.
Here are the steps to reproduce:

Prerequesites:
The hidden input fields with ids "termsofAccessHiddenLT" and "fileAccessRequestHiddenLT" must be removed in dataset-license-terms.xhtml

dataverse/src/main/webapp/dataset-license-terms.xhtml

Lines 341 to 342 in ac1454b

	<o:inputHidden id="termsofAccessHiddenLT" value="#{termsOfUseAndAccess.termsOfAccess}" />
	<o:inputHidden id="fileAccessRequestHiddenLT" value="#{termsOfUseAndAccess.fileAccessRequest}" />

(in our case, we just wanted to display the licenses list and the terms of use field, and removed everything else)

Steps:

1. Create a new dataset
2. Go to Terms Tab, edit the terms (e.g. changing the license) and click on save => The dataset is saved twice due to the javascript code.
   At first in the catch-clause, which is called because the hidden fields do not exist:

   dataverse/src/main/webapp/dataset.xhtml

   Line 1891 in ac1454b

   datasetSaveCommand();

   
   and then in the further code:

   dataverse/src/main/webapp/dataset.xhtml

   Line 1897 in ac1454b

   datasetSaveCommand();

   
   The DatasetPage Scope keeps the version after the first save, the database contains the newer version of the second save.
3. Directly click on Publish afterwards -> OptimisticLockingError because the versions of the page scope and the database differ.

[mreekie]

Prio meeting with Stefano.

• Moved from Community Backlog to ordered backlog

[kcondon]

Hi @haarli , would you please refresh this branch from develop since we've since update the version and this prevents us from building and testing. Thanks!