Sonarcube Fixes #9320
Merged
Sonarcube Fixes #9320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2023
qqmyers
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
FWIW - issues had combined size of 6. |
scolapasta
moved this from Ready for Review ⏩
to Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
9280 using JsonUtil methods looks good, although I have also put the JsonUtil methods on the next queue for examination as well. There are several places called out in 9282 - I think there were a total of 8 - that have not yet been addressed |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🔎
to Ready for QA ⏩
Jan 24, 2023
|
Sprint review:
|
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Jan 26, 2023
|
sprint kickoff
|
mreekie
added
the
Size: SprintTail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is a branch/draft PR to collect tech-debt fixes for sonarcube.
Which issue(s) this PR closes:
Closes #9280
Closes #9282
Special notes for your reviewer:
Suggestions on how to test this: Regression testing plus running through Sonarcube to assure the matching issues are gone.
#9280 is in the Files API {id}/metadata call (trivial fix replacing code with the same code in the JsonUtil class).
#9282 is a change in the tabular download subset functionality - not sure if there's already a test or guides example for that call.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: