Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

during password reset, users asked to accept term but there is no checkbox #9326

Closed
pdurbin opened this issue Jan 25, 2023 · 6 comments · Fixed by #9652
Closed

during password reset, users asked to accept term but there is no checkbox #9326

pdurbin opened this issue Jan 25, 2023 · 6 comments · Fixed by #9652
Labels
Feature: Account & User Info Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Jan 25, 2023

When resetting their password users see "Please, accept the new terms of use before continuing."

However, there is no checkbox:

Screen Shot 2023-01-25 at 12 14 04 PM

Tested on the Payara server. Not sure if it's an issue in 5.12.1 or develop.

@mreekie mreekie added the D: Payara 6 Upgrade Issues and PRs about the move to Jakarta EE 10 + Payara 6 label Jan 25, 2023
@pdurbin
Copy link
Member Author

pdurbin commented Jan 26, 2023

I just wanted to add that the proper fix is probably to simply remove "Please, accept the new terms of use before continuing."

That is, there's no need to add a checkbox. It wasn't there before. It reminds me of how term stuff now also pops up when password are reencrypted with a new algorithm. Here's a screenshot from https://github.com/IQSS/dataverse-security/issues/29

209150377-ed0d8cb2-e8f5-4b47-bf30-3c76e225dc0e

Again, just removing the message about terms should be the fix. I'll give this a 3. And whoever picks it up should try to reproduce it in develop first, of course. My money is on it being a bug there and not specific to Payara 6.

@pdurbin pdurbin added Type: Bug a defect Feature: Account & User Info Size: 3 A percentage of a sprint. 2.1 hours. labels Jan 26, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 22, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@mreekie mreekie added this to New in deleteMeAfterTesting via automation Feb 23, 2023
@mreekie mreekie removed this from New in deleteMeAfterTesting Feb 23, 2023
@landreev landreev moved this from ▶ SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Mar 15, 2023
@qqmyers
Copy link
Member

qqmyers commented May 19, 2023

FWIW: I can confirm that this is not Payara6 specific - it happens now at dataverse.harvard.edu.

@cmbz cmbz removed the D: Payara 6 Upgrade Issues and PRs about the move to Jakarta EE 10 + Payara 6 label May 24, 2023
@cmbz
Copy link

cmbz commented May 24, 2023

Removed Payara 6 label because the issue occurs in current branches, too.

@pdurbin pdurbin changed the title Payara 6: during password reset, users asked to accept term but there is no checkbox during password reset, users asked to accept term but there is no checkbox May 24, 2023
@cmbz cmbz moved this from This Sprint 🏃‍♀️ 🏃 to ▶ SPRINT READY in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) May 24, 2023
@pdurbin pdurbin self-assigned this Jun 16, 2023
@pdurbin pdurbin moved this from ▶ SPRINT READY to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jun 16, 2023
@jggautier
Copy link
Contributor

Does there have to be a message? Could we just remove it? Or does this message show up only when the user tried using a password that doesn't meet the requirements?

@pdurbin
Copy link
Member Author

pdurbin commented Jun 20, 2023

Another possibility would be to remove the message altogether, yes.

@jggautier
Copy link
Contributor

Looks like the PR that's in the code review column now (#9652) edits the message instead of removing it. I suspect removing it like @pdurbin wrote earlier would be better but maybe that can be reviewed after the move to the SPA.

kcondon added a commit that referenced this issue Jul 11, 2023
better message when picking a new password #9326
@pdurbin pdurbin added this to the 5.14 milestone Jul 11, 2023
@pdurbin pdurbin removed their assignment May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Account & User Info Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants