Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nonstopmode to build guides PDF, link to preview #9277 #9474

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Mar 24, 2023

What this PR does / why we need it:

There is interest in a PDF version of the guides.

In this pull request we advertise the fact that we (as of today) are building a PDF at http://preview.guides.gdcc.io/_/downloads/en/develop/pdf/

We set expectations that this is highly experimental.

It's the same job that builds the regular HTML preview at http://preview.guides.gdcc.io/en/develop/

That is to say, the build happens when we merge a pull request.

In addition, with an eye toward improving the PDF, a Docker command has been added to the "writing docs" section of the dev guide. Again, expectations are set that these are early days.

The key to getting to getting the PDF to build at all is "nonstopmode". Perhaps some day we can remove this as we clean up the guides. I think we should do this in small chunks, which is our usual practice.

Which issue(s) this PR closes:

Special notes for your reviewer:

Not really.

Suggestions on how to test this:

Try the Docker command.

Uncomment the PDF building code at https://jenkins.dataverse.org/job/guides.dataverse.org/ and the the nonstopmode from the Docker command to see if a PDF can be build. If so, at release time, consider building the PDF and having it be available at http://guides.dataverse.org/en/latest/Dataverse.pdf (where it has lived off and on over the years).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

Yes, included.

Additional documentation:

Included.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Ready for Review ⏩ to Ready for QA ⏩ Mar 27, 2023
@kcondon kcondon self-assigned this Mar 28, 2023
@kcondon kcondon merged commit 753ee84 into develop Mar 28, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Mar 28, 2023
@kcondon kcondon deleted the 9277-nonstopmode-pdf-guides branch March 28, 2023 14:12
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Correcting the Sphinx documentation PDF build
3 participants