IQSS/9431-support checksum alg in direct uploads #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update crypto-js to 4.0.0 use local copies of crypto-js files only load js when needed add api call to get fixity/checksum alg
mreekie
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
mreekie
moved this from Ready for Review ⏩
to ▶ SPRINT READY
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
moved this from ▶ SPRINT READY
to This Sprint 🏃♀️ 🏃
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
moved this from This Sprint 🏃♀️ 🏃
to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
I didn't test the actual fix but I did check that http://localhost:8080/api/files/fixityAlgorithm responds and improved the docs a bit. I'm approving this.
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for Review ⏩
to Ready for QA ⏩
Jun 16, 2023
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:This PR addresses in two ways:
Which issue(s) this PR closes:
Closes #9431
Special notes for your reviewer: fairly straight forward, just wasn't implemented (support for direct upload may predate the multiple algorithm implementation?). Also include minor code cleanup/recommended fixes from my IDE in the direct upload javascript.
Suggestions on how to test this: Do direct upload via the UI with various fixity algorithms specified and assure that those uploads use the correct algorithm. Try the new api/files/fixityAlgorithm call and verify it returns the current algorithm.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
included
Additional documentation:
new api call documented, older admin call to update the alg on existing files also improved.