Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes previewers work on files in deaccessioned datasets. #9455 #9491

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:

Self-explanatory. We recently discovered that external previewers (pdf, image, etc.) did not work in deaccessioned versions. This one-line PR fixes it.

Which issue(s) this PR closes:

Closes #9455

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Mar 31, 2023

Coverage Status

Coverage: 20.184%. Remained the same when pulling ee1311f on 9455-deaccessioned-preview into 82cef32 on develop.

@landreev landreev added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Apr 3, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Ready for Review ⏩ to Ready for QA ⏩ Apr 3, 2023
@kcondon kcondon self-assigned this Apr 4, 2023
@kcondon kcondon merged commit 97310b3 into develop Apr 4, 2023
3 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Apr 4, 2023
@kcondon kcondon deleted the 9455-deaccessioned-preview branch April 4, 2023 19:22
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Previewers don't work on files in deaccessioned versions
5 participants