New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQSS/9544 - Migrate API fixes #9545
Merged
kcondon
merged 11 commits into
IQSS:develop
from
GlobalDataverseCommunityConsortium:migrateFixes
Jul 7, 2023
Merged
IQSS/9544 - Migrate API fixes #9545
kcondon
merged 11 commits into
IQSS:develop
from
GlobalDataverseCommunityConsortium:migrateFixes
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the first place that terms.getDatasetVersion() was ever called on a new TermsOfUseAndAccess object.
To support Fake and Perma providers correctly in ImportDatasetCommand.
qqmyers
added
Size: 10
A percentage of a sprint. 7 hours.
GDCC: DANS
related to GDCC work for DANS
labels
Apr 20, 2023
mreekie
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
May 15, 2023
mreekie
moved this from Ready for Review ⏩
to ▶ SPRINT READY
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
May 15, 2023
cmbz
moved this from ▶ SPRINT READY
to This Sprint 🏃♀️ 🏃
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
Jun 21, 2023
cmbz
moved this from This Sprint 🏃♀️ 🏃
to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
Jun 22, 2023
sekmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
Jun 26, 2023
sekmiller
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, except that the logging still refers to alreadyExists instead of the new alreadyRegistered in most cases. Also this branch needs to be updated from Dev
sekmiller
added
the
Status: Waiting
issues in need of input from someone currently unavailable
label
Jun 29, 2023
qqmyers
removed
the
Status: Waiting
issues in need of input from someone currently unavailable
label
Jul 5, 2023
sekmiller
approved these changes
Jul 5, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from In Review 🔎
to Ready for QA ⏩
Jul 5, 2023
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
Jul 7, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR has 3 commits to address three related issues uncovered in trying to use the Dataset Migration API via the DVUploader.
Which issue(s) this PR closes:
Closes #9544
Special notes for your reviewer:
Rather than adding a boolean param, there could be two methods - I just couldn't think of reasonable names - something like conflictingPIDExists() and previouslyRegisteredPIDFound() ? The problem is that, for Handle/DOI, these just return the same thing and the names still reflect that. Perhaps a rewrite to only call alreadyRegistered() if it makes sense, e.g. a if(hasRegistry()) then check alreadyRegistered()? I think that's more work than adding a param, and potentially easier to mess up, but I'm game if that's what's requested. This is something that should be fixed for 5.14 as I think DANS will want to migrate with PermaLinks.
Suggestions on how to test this:
Any call to /api/dataverses/$DATAVERSE_ID/datasets/:startmigration would test the fix for #1, #2 could be tested by going to /citation?persistentId= with a non existent PID. To test #3, one could configure to use PermaLinks and call the Dataset Migration API as in the guides or try the DVUploader with an archival bag (which would have to be created), e.g.
java -jar DVUploader-v1.2.0.jar -key=5c0332b9-c546-4e9d-a497-2f9cf668e24e -did=perma:DANSPIDFK212 -server=http://ec2-3-215-16-135.compute-1.amazonaws.com -bag=file:/c:/NetBeansProjects/dataverse-uploader/target/perma-danspidfk212v2.0.zip -createIn=root
The latter would also test #1 and #2. For regression, probably the basic tests of create/publish datasets is enough, perhaps just with DOIs.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: The fact that the Migration API is broken in 5.13 and now fixed could be put in a release note, but this problem hasn't been noticed until now. The bigger part of the PR is fixing PermaLinks which are 5.14.
Additional documentation: