allow war files to be deployed by the base image #9548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...not just exploded war files. In the container guide, we say both work.
pdurbin
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
poikilotherm
approved these changes
Apr 24, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for Review ⏩
to Ready for QA ⏩
Apr 24, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Apr 24, 2023
pdurbin
added a commit
to IQSS/dataverse-people
that referenced
this pull request
Apr 26, 2023
For this we needed IQSS/dataverse#9548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://guides.dataverse.org/en/5.13/container/base-image.html#locations says, "Any EAR or WAR file, exploded WAR directory etc are autodeployed on start" but only exploded WAR directories are currently supported. This PR allows WAR fles to be deployed.
Which issue(s) this PR closes:
Closes NONE
Special notes for your reviewer:
I tested this with a WAR file I built from https://github.com/IQSS/dataverse-people
Suggestions on how to test this:
I build the base image locally with a custom tag and used the following line in a Dockerfile to copy the war into place.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.