9575 fix CI for app images pushing #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of pull requests from forks, a run does not have access to secrets. Thus we check if we can access the secrets, otherwise we skip the pushing part (which will rely on a comment trigger).
poikilotherm
added
the
Component: Containers
poikilotherm
force-pushed
the
9575-fix-ghcr-pushes
branch
from
293464c
to
77af5c1
Compare
pdurbin
approved these changes
May 8, 2023
There was a problem hiding this comment.
This is what we talked about at tech hours last week. Thanks, @poikilotherm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For PRs from forks we don't want failing jobs because of no access to secrets. Instead, we run the deploy tasks only when available or if triggered by a comment from a maintainer.
Which issue(s) this PR closes:
Special notes for your reviewer:
The PR command can only be tested after we merge this, as the dispatching must be present in the default branch.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
I don't know. Probably not?
Additional documentation:
None so far. Shall we write some docs somewhere in the guides, so we let people know about the "/push-image" command?