New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets API extension for the SPA #9592
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
57437d1
to
16ab0e8
Compare
This comment has been minimized.
This comment has been minimized.
…etVersion endpoint
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview application image as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged develop in and cleaned up the tests (happy to explain more).
I left a bit of feedback on exposing database settings.
This PR needs docs. I already mentioned this to @GPortas in Braga and he said he'd add them but he's on a well-deserved vacation this week.
If we do make changes to this PR (how the APIs work), it will mean we have to change the js-dataverse PR as well.
@@ -3849,4 +3854,62 @@ public Response getExternalToolDVParams(@Context ContainerRequestContext crc, | |||
return wr.getResponse(); | |||
} | |||
} | |||
|
|||
@GET | |||
@Path("summaryFieldNames") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a thread in Slack about being consistent in how we expose database settings: https://iqss.slack.com/archives/C010LA04BCG/p1686603802872139
This might be fine but we should make an active decision because we'll be doing this a lot for the SPA. It needs to know how the backend is configured.
@@ -10,6 +10,7 @@ | |||
import edu.harvard.iq.dataverse.authorization.RoleAssignee; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just putting this here the top but this PR needs:
- docs
- a release note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added docs and a release note. Approved.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it:
This PR includes new endpoints to support the SPA. Specifically, to obtain the summary field names and to obtain a dataset version through a private url token.
Edit 29/05: Included endpoints for obtaining the dataset citation text
Which issue(s) this PR closes:
Special notes for your reviewer:
The new endpoints are consumed from:
Suggestions on how to test this:
For obtaining the Dataset summary fields:
curl -X GET http://localhost:8080/api/datasets/summaryFieldNames
If you want to test custom field retrieval, update the
CustomDatasetSummaryFields
setting.For obtaining a Dataset version from a private URL token:
First, create a private URL, you can use the UI for that:
Copy the token from the generated URL, and send it to the new endpoint like this:
curl -X GET http://localhost:8080/api/datasets/privateUrlDatasetVersion/<PRIVATE_URL_TOKEN>
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
Not sure
Additional documentation:
N/A