Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and de-duplicate role creation information. #9646

Merged
merged 8 commits into from
Jul 24, 2023

Conversation

lmaylein
Copy link
Contributor

What this PR does / why we need it:

Some information about creating roles is duplicated, others were missing or not linked.

Which issue(s) this PR closes:

Closes none

Special notes for your reviewer:

I ask that you critically examine my English wording.
Please check also the new cross references because I'm not sure if the are rendered correctly

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

no

Additional documentation:

@lmaylein lmaylein closed this Jun 16, 2023
@lmaylein lmaylein reopened this Jun 16, 2023
@pdurbin pdurbin added the Size: 0.5 A percentage of a sprint. 0.35 hours label Jul 21, 2023
@cmbz cmbz added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Jul 21, 2023
@pdurbin pdurbin self-assigned this Jul 24, 2023
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jul 24, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmaylein this is a nice cleanup. Thanks! I added some more cross links. I'd say this is ready for QA.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Jul 24, 2023
@pdurbin pdurbin removed their assignment Jul 24, 2023
@pdurbin
Copy link
Member

pdurbin commented Jul 24, 2023

@lmaylein oh, one last thing. Next next time, please create a new branch instead of calling the branch "develop". We can work around this but having a new branch name makes it easier for us to update the branch. For details, please see this issue:

Thanks again!

@kcondon kcondon self-assigned this Jul 24, 2023
@kcondon kcondon merged commit 77b7769 into IQSS:develop Jul 24, 2023
3 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Ready for QA ⏩ to Done 🚀 Jul 24, 2023
@pdurbin pdurbin added this to the 5.14 milestone Jul 24, 2023
@lmaylein
Copy link
Contributor Author

@lmaylein oh, one last thing. Next next time, please create a new branch instead of calling the branch "develop". We can work around this but having a new branch name makes it easier for us to update the branch. For details, please see this issue:

Thanks for the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants