Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation about metadata block display facet properties #9673

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Jun 21, 2023

What this PR does / why we need it:
Improved documentation for Metadata block facets. Based on a conversation with @jggautier and @pdurbin

Which issue(s) this PR closes: N/A

Special notes for your reviewer: N/A

Suggestions on how to test this: N/A

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: No

Additional documentation: This PR is documentation only

@pdurbin pdurbin added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Jun 22, 2023
@pdurbin pdurbin self-assigned this Jun 22, 2023
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jun 22, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @abujeda!

Also, nice playing soccer with you in Braga, by the way. We'll get you next time! ⚽

I made a small tweak. The preview at https://dataverse-guide--9673.org.readthedocs.build/en/9673/admin/metadatacustomization.html#metadatablock-properties looks good. Approved!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Jun 22, 2023
@abujeda
Copy link
Contributor Author

abujeda commented Jun 22, 2023

Great!! Thanks @pdurbin.

Re Soccer: No team is going to get us while I am the goalkeeper 💪 (jajajaja)
It was really great playing the match!!

@kcondon kcondon assigned kcondon and unassigned pdurbin and kcondon Jun 22, 2023
@kcondon kcondon merged commit 94c9a9f into IQSS:develop Jun 22, 2023
2 of 3 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Jun 22, 2023
@pdurbin pdurbin added this to the 5.14 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants