Remove temporary additions to json export from #9175 #9677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
sekmiller
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
sekmiller
approved these changes
Jun 29, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from In Review 🔎
to Ready for QA ⏩
Jun 29, 2023
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Jul 5, 2023
Merged
kcondon
added a commit
that referenced
this pull request
Jul 6, 2023
…-external_exporters Update for #9677
kcondon
added a commit
that referenced
this pull request
Jul 20, 2023
…-external_exporters DANS - 9707/Second fix for #9677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: In creating the ability to provide variable-level metadata in external exporters, I originally added the required info to the internal json representation. After confirming the approach would work, I created a separate 'fileDetails' json export and adapted the DDIExporter (actually DDIExportUtil class) to use it, but the forgot to restore the internal json representation to its original contents. The accidental additions to that json weren't noticed before the original PR was merged.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: Verify that the default json export for a tabular file (with variable-level metadata) doesn't include elements for "restricted", "fileMetadataId", "dataTables", or "varGroups". (The develop branch would have these prior to this PR, but the version 5.13 release would not.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: