Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy beta testing action to enable api-session-auth feature flag #9752

Merged

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Aug 3, 2023

What this PR does / why we need it:
Adds a missing step to the beta testing environment deployment GitHub action.

Which issue(s) this PR closes:
N/A

Special notes for your reviewer:
The action worked before, but requests from the SPA to the backend were failing because the feature flag for the cookie authentication was not enabled.

Suggestions on how to test this:

You can see how the action works in my fork repository, where I have committed several times in the develop branch, causing these events to trigger the action:
https://github.com/GPortas/dataverse/actions/runs/5749971477

These actions have updated the environment, available at the following URL:
https://beta.dataverse.org/

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Not sure.

Additional documentation:

N/A

Additional documentation:

@GPortas GPortas added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Aug 3, 2023
@GPortas GPortas changed the title Fix deploy beta tesing action to enable api-session-auth feature flag Fix deploy beta testing action to enable api-session-auth feature flag Aug 3, 2023
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question.

.github/workflows/deploy_beta_testing.yml Show resolved Hide resolved
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Aug 4, 2023
@pdurbin pdurbin assigned pdurbin and GPortas and unassigned pdurbin Aug 4, 2023
@GPortas GPortas removed their assignment Aug 5, 2023
@GPortas GPortas requested a review from pdurbin August 5, 2023 14:18
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it makes sense.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Aug 6, 2023
@pdurbin pdurbin removed their assignment Aug 6, 2023
@kcondon kcondon self-assigned this Aug 7, 2023
@kcondon kcondon merged commit dc06cdd into develop Aug 7, 2023
2 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Aug 7, 2023
@kcondon kcondon deleted the fix_enable_session_auth_deploy_beta_testing_action branch August 7, 2023 13:53
@pdurbin pdurbin added this to the 6.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants