IQSS/9758 Fix Tabular Tag entry from file table kebab menu #9759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolapasta
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
qqmyers
added a commit
to QualitativeDataRepository/dataverse
that referenced
this pull request
Aug 4, 2023
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
This works and will merge but note there is still one slight behavior that is missing: from dataset page edit_files->tags, when a tag is selected, it immediately shows up at the top of the edit popup whereas from the kebab and edit_files->metadata it does not appear when selected in the popup but does on save |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Done 🚀
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This fixes a bug in the kebab menu
Which issue(s) this PR closes:
Closes #9758
Special notes for your reviewer: Fixed this just because it slowed me down in debugging the 5.14 DDI infinite loop issue...
Suggestions on how to test this: With a tabular file, click the kebab menu metadata entry and try to add a tabular tag(s). Clicking save will often not work. (I've seen one change work I think - possibly after hitting the checkbox for one tag repeatedly.) With the PR, adding tabular tags should always work from the kebab menu. Regression test: this should not affect changing tabular tags by selecting a file row and using the file table's main Edit button to add a tabular tag.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: