9769 fix docker push #9777
Merged
9769 fix docker push #9777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By ensuring pushes to Docker Hub are only executed when based on develop or master branch, we avoid breaking the images on the Hub: simply skip the deploy job on wrong pushed to branch.
poikilotherm
added
the
Component: Containers
poikilotherm
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
moved this from Ready for Review ⏩
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
moved this from IQSS Team - In Progress 💻
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
pdurbin
approved these changes
Aug 14, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from In Review 🔎
to Ready for QA ⏩
Aug 14, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the container push workflow, sending feature branch preview images to Docker Hub, breaking workflows for many.
Which issue(s) this PR closes:
Closes #9769
Special notes for your reviewer:
None
Suggestions on how to test this:
Must be merged to see effect. Push a commit to a feature branch (updated to latest develop) and see how the image deployment is skipped. Cannot be seen from this PR as from a forked repo, could be tested from cloning the branch into an upstream repo one.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None