Upgrade Solr to 9.3.0 #9787
Merged
Upgrade Solr to 9.3.0 #9787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all Solr references from 8.11.1 to 9.3.0 and make sure you can spin up containers. schema.xml was copied from solr-9.3.0/server/solr/configsets/_default/conf/managed-schema.xml (Note managed-schema.xml as there is no schema.xml upstream.) solrconfig.xml was copied from solr-9.3.0/server/solr/configsets/_default/conf/solrconfig.xml API tests will fail, of course, because we have not yet added our Dataverse-specific config. We'll be moving it from these files and then deleting them: conf/solr/8.11.1/schema.xml conf/solr/8.11.1/solrconfig.xml
"To improve security, XSLTResponseWriter has been moved to the scripting Module instead of shipping as part of Solr core. This module needs to be enabled explicitly." -- https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc See also https://stackoverflow.com/questions/74118537/solr-9-org-apache-solr-common-solrexceptionorg-apache-solr-common-solrexcepti
pdurbin
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
moved this from Ready for Review ⏩
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -52,7 +52,7 @@ echo "Ensuring Unix user '$SOLR_USER' exists" | |||
| useradd $SOLR_USER || : | |||
| DOWNLOAD_DIR='/dataverse/downloads' | |||
| PAYARA_ZIP="$DOWNLOAD_DIR/payara-6.2023.7.zip" | |||
| SOLR_TGZ="$DOWNLOAD_DIR/solr-8.11.1.tgz" | |||
| SOLR_TGZ="$DOWNLOAD_DIR/solr-9.3.0.tgz" | |||
| if [ ! -f $PAYARA_ZIP ] || [ ! -f $SOLR_TGZ ]; then | |||
| echo "Couldn't find $PAYARA_ZIP or $SOLR_TGZ! Running download script...." | |||
| cd $DOWNLOAD_DIR && ./download.sh && cd | |||
pdurbin
moved this from IQSS Team - In Progress 💻
to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
4 tasks
Conflicts: downloads/download.sh scripts/vagrant/setup.sh
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
moved this from Ready for Review ⏩
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pdurbin
moved this from IQSS Team - In Progress 💻
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
@pdurbin: Thanks for the update. I have a smaller request. Would it be possible to link the SOLR documentation [1] that explains why the scripting module is needed [1] https://solr.apache.org/guide/solr/latest/upgrade-notes/major-changes-in-solr-9.html#security-2 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
kcondon
moved this from QA ✅
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pdurbin
moved this from IQSS Team - In Progress 💻
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
kcondon
moved this from Ready for QA ⏩
to QA ✅
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
landreev
reviewed
Aug 28, 2023
doc/release-notes/9260-solr930.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| Solr has been upgraded to Solr 9. You must install Solr fresh and reindex. | |||
|
|
|||
| If you have custom metadata blocks installed, you must update your Solr schema.xml to include your custom fields. Please see https://guides.dataverse.org/en/9260-solr930/admin/metadatacustomization.html#updating-the-solr-schema | |||
There was a problem hiding this comment.
Any chance we could add just a couple of sentences here, clarifying what needs to be done? I fear this may confuse some people. Instead of you must update your solr schema, maybe spell it out as you must copy the schema.xml from the source tree, here, then update it to include your custom fields, see ... for instructions. If you don't use custom metadata blocks, use the schema.xml supplied in the source tree as is. **Do not attempt to reuse your existing 8.11 schema.xml!** - something along these lines?
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA ✅
to Ready for QA ⏩
Aug 28, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Aug 28, 2023
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Installations (and potential installations) have asked us to upgrade Solr.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Make sure to use the newNo longer needed now that we merged #9826 into this PR.-Dsolr.modules=scriptingflag when starting Solr.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
The guides have been updated.