Update the beta-testing deploy GitHub action to use "flat" GitHub secrets #9791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPortas
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
I didn't test this but it looks straightforward to me. Approved.
As a reminder, the only reason we can't use environments in GitHub Actions is that @IQSS is on a legacy GitHub plan.
I kicked off a discussion about this here: https://iqss.slack.com/archives/C02UDJV9T/p1691679697106509
More evidence that it's the legacy plan: https://github.com/orgs/community/discussions/26262#discussioncomment-4960196
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for Review ⏩
to Ready for QA ⏩
Aug 17, 2023
|
@GPortas Is there any action that needs to take place on my part? Sorry if I am missing something obvious. |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the beta-testing deploy GitHub action to use "flat" GitHub secrets instead of GitHub environments with secrets, since the GitHub organization does not support that feature.
Also updates the action to use payara6 commands.
Which issue(s) this PR closes:
Special notes for your reviewer:
New GitHub secrets are already configured by myself in the IQSS/dataverse repository.
Suggestions on how to test this:
You can see how my fork correctly deploys the application using the implemented changes:
https://github.com/GPortas/dataverse/actions/runs/5892650217/job/15982711141
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
No
Additional documentation:
N/A