Update to Payara 6.2023.8 #9795
Conversation
poikilotherm
added
Component: Code Infrastructure
poikilotherm
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Looks good to me. The only remaining instance of .7 is in a comment that seems ok to leave alone (though we probably could remove this comment as it's just a history lesson 😜 ):
% ack 6.2023.7 -C2
pom.xml
198- <artifactId>payara-api</artifactId>
199- <scope>provided</scope>
200: <!-- Note: The version was provided by Payara BOM till 6.2023.7, when they removed the Core BOM from it as
201- meant for internal use only. Simply referencing the version property here solves the problem. -->
202- <version>${payara.version}</version>
I'm sending this to QA since @kcondon is already experimenting with the .8 version anyway.
|
Oh, wait, we should revert da5193f as I mentioned in the issue: |
|
Ok, reverted in 20d2aa2. Now it should be ready for testing. |
|
Please note that this reversion will make the deployment fail because it will be missing the |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
As of both commits in this pull request, all API tests are passing, according to my test runner:
|
|
@pdurbin dumb question: is your API test runner rebuilding the base image or pulling it from Docker Hub? (I can't access the logs in a success run, so I can't really tell) |
|
@poikilotherm it's rebuilding the base image: https://github.com/pdurbin/dataverse-api-test-runner/blob/8511e536424657ee041960ea3981a051889ebfc8/.github/workflows/payara6.yml#L17 Should I move the runner under @IQSS or @gdcc and set permissions so more of us can make use of it, including seeing logs? (I know we plan to parts of it to the main repo in #9790 as discussed in the container meeting yesterday.) |
|
Great. Let's give Kevin a heads up though that he might hit the issue. As we're not yet sure what caused the error for him (it might be OK now with 6.2023.8 or it might still be some other issue), we can keep that in mind to enable QA. |
|
WRT moving to GDCC: sounds good, I like! |
|
What this PR does / why we need it:
Updating to new Payara release 6.2023.8
Which issue(s) this PR closes:
Special notes for your reviewer:
None
Suggestions on how to test this:
As with any new Payara version...?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
None