Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes broken basic search (#9803) #9816

Merged
merged 2 commits into from Aug 23, 2023
Merged

fixes broken basic search (#9803) #9816

merged 2 commits into from Aug 23, 2023

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:

a 3-character pr that fixes the broken basic search

Which issue(s) this PR closes:

Closes #9803

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Aug 22, 2023

Coverage Status

coverage: 20.37%. remained the same when pulling 8c259b5 on 9803-basic-search-broken into 45a3936 on develop.

@github-actions

This comment has been minimized.

@scolapasta scolapasta added this to the 6.0 milestone Aug 22, 2023
@scolapasta scolapasta added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Aug 22, 2023
@scolapasta scolapasta moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Aug 22, 2023
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9803-basic-search-broken
ghcr.io/gdcc/configbaker:9803-basic-search-broken

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@kcondon kcondon self-assigned this Aug 23, 2023
@kcondon
Copy link
Contributor

kcondon commented Aug 23, 2023

The basic search functions now for most searches. I am seeing an exception when I search on '50by1000' in all search modes: basic, navbar, adv search (filename). This works on demo but with uneven results: navbar returns no results, perhaps only searching on datasets? but on demo basic search returns a list of files named 50by1000 and adv search (filename) on demo also returns files named 50by1000.

Here is the url for adv search (filename) for both internal and demo:
Internal: https://dataverse-internal.iq.harvard.edu/dataverse/root/?q=fileName%3A50by1000
Demo: https://demo.dataverse.org/dataverse/demo/?q=fileName%3A50by1000

Here is the screenshot
Screen Shot 2023-08-23 at 9 53 49 AM

Here is the log file:
basic_search_err.txt

@kcondon
Copy link
Contributor

kcondon commented Aug 23, 2023

This was due to a mismatch between db and index. So, a reindex resolved/resynced them.

@kcondon kcondon merged commit bf04fda into develop Aug 23, 2023
14 of 15 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Aug 23, 2023
@kcondon kcondon deleted the 9803-basic-search-broken branch August 23, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Payara 6: Basic search no longer works due to extra, blank url query param
5 participants