New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New handlnet library 9.3.1 from maven central (9805) #9817
Conversation
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. Tests are passing. I didn't do any testing of my own. Approved.
@landreev This works but there is some weird, noisy logging for a single dataset handle: |
Hmm. It really is chatty - and it is logging all that seemingly debug-level stuff as |
It crossed my mind that may be it is SEVERE because it trying to warn us that some cert is about to expire:
But doesn't seem to be the case; that must be the expiration date of the handlenet auth. ticket. @kcondon confirmed that this is not unique to this 9.3.1 version from maven central (going back to the local_lib version 8.* results in these same messages in the log). |
I took a quick look at the handles-client library code. They are simply dumping these messages into stderr:
It is possible that this is something new to p6 (or even p6 under jdk17), that stderr output automatically gets logged as level SEVERE in server.log. Although we would need to check to confirm how it behaved under p5 if we wanted to know for sure. |
The logging was a preexisting issue, shows up in 5.14 too on p5. Not an easy way to fix currently. |
What this PR does / why we need it:
Self-explanatory.
Tested basic functionality (creating and publishing a dataset with a handle), appears to be working.
Which issue(s) this PR closes:
Closes #9805
Special notes for your reviewer:
Suggestions on how to test this:
Our QA handlenet instance appears to be running and working fine.
In order to test, the following jvm options are needed:
The file path in the first one is where the key file is stored on dataverse-internal. The second option is probably not necessary at all (since it's empty), but we had it in the old config for whatever reason.
The persistent identifier-related database settings should be as follows:
Let me know if you run into any problems with this setup.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: