Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New handlnet library 9.3.1 from maven central (9805) #9817

Merged
merged 1 commit into from Aug 28, 2023

Conversation

landreev
Copy link
Contributor

What this PR does / why we need it:

Self-explanatory.
Tested basic functionality (creating and publishing a dataset with a handle), appears to be working.

Which issue(s) this PR closes:

Closes #9805

Special notes for your reviewer:

Suggestions on how to test this:

Our QA handlenet instance appears to be running and working fine.
In order to test, the following jvm options are needed:

<jvm-options>-Ddataverse.handlenet.admcredfile=/usr/local/dvn-admin/hdl/admpriv.bin</jvm-options>
<jvm-options>-Ddataverse.pid.handlenet.key.passphrase=</jvm-options>

The file path in the first one is where the key file is stored on dataverse-internal. The second option is probably not necessary at all (since it's empty), but we had it in the old config for whatever reason.

The persistent identifier-related database settings should be as follows:

    ":Protocol": "hdl"
    ":Authority": "20.500.12050"
    ":Shoulder": ""

Let me know if you run into any problems with this setup.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@landreev landreev added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Aug 22, 2023
@scolapasta scolapasta added this to the 6.0 milestone Aug 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 20.37%. remained the same when pulling 89f6d7b on 9805-new-handles-lib into 45a3936 on develop.

@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9805-new-handles-lib
ghcr.io/gdcc/configbaker:9805-new-handles-lib

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Tests are passing. I didn't do any testing of my own. Approved.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Ready for Review ⏩ to Ready for QA ⏩ Aug 22, 2023
@kcondon kcondon self-assigned this Aug 25, 2023
@kcondon
Copy link
Contributor

kcondon commented Aug 25, 2023

@landreev This works but there is some weird, noisy logging for a single dataset handle:
Note that informational entries are listed as SEVERE and there is a comment about a deprecated auth method.
hdl_create_pub_log.txt

@landreev
Copy link
Contributor Author

Hmm. It really is chatty - and it is logging all that seemingly debug-level stuff as SEVERE. I'll need to check their docs and see if it's a thing, that we need to disable explicitly. (?)

@landreev
Copy link
Contributor Author

landreev commented Aug 25, 2023

It crossed my mind that may be it is SEVERE because it trying to warn us that some cert is about to expire:

sending HDL-HTTP request (version=2.10; oc=1; rc=0; snId=0 caCrt noAuth expires:Sat Aug 26

But doesn't seem to be the case; that must be the expiration date of the handlenet auth. ticket.

@kcondon confirmed that this is not unique to this 9.3.1 version from maven central (going back to the local_lib version 8.* results in these same messages in the log).
We'll revisit it on Mon.

@landreev
Copy link
Contributor Author

I took a quick look at the handles-client library code. They are simply dumping these messages into stderr:

System.err.println("  sending HDL-TCP request (" + req + ") to " + Util.rfcIpPortRepr(addr, port));

It is possible that this is something new to p6 (or even p6 under jdk17), that stderr output automatically gets logged as level SEVERE in server.log. Although we would need to check to confirm how it behaved under p5 if we wanted to know for sure.

@kcondon
Copy link
Contributor

kcondon commented Aug 28, 2023

The logging was a preexisting issue, shows up in 5.14 too on p5. Not an easy way to fix currently.

@kcondon kcondon merged commit 3f5625f into develop Aug 28, 2023
14 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA ✅ to Done 🚀 Aug 28, 2023
@kcondon kcondon deleted the 9805-new-handles-lib branch August 28, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

move from local_lib handle-8.1.1.jar to Maven Central version 9.x
5 participants