get tests passing in Jenkins #9855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
moved this from Ready for Review ⏩
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
pdurbin
moved this from IQSS Team - In Progress 💻
to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
scolapasta
approved these changes
Aug 30, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for Review ⏩
to Ready for QA ⏩
Aug 30, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Aug 31, 2023
|
This PR was merged but strangely Jenkins didn't kick off a test run of the IQSS-dataverse-develop job. I just kicked it off manually: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1462/ |
|
@pdurbin The tests passed on my internal build though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before we release 6.0, all tests should be passing on https://jenkins.dataverse.org/job/IQSS-dataverse-develop/
Which issue(s) this PR closes:
Special notes for your reviewer:
Just some more sleep. 😴
As I mentioned at standup, I'm also concerned that sometimes Dataverse won't deploy in 90 seconds. Here's a related issue:
We may need to bump up the value in Ansible from 90 seconds.
Also, please note that I didn't fix FitsIT in this PR. The fix for that is over here:
The first commit on this PR passed except for FitsIT: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9855/1/testReport/
I followed up with another pre-emptive doubling of sleep in a second commit for a test that failed previously.
Suggestions on how to test this:
Check Jenkins. Are the tests passing?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None.