Extend DataFile API payload and new endpoints for Files (getHasBeenDeleted) and Access (userFileAccessRequested) #9900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DataFile API payload
…S/dataverse into 9851-datafile-payload-extension
GPortas
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
This comment has been minimized.
This comment has been minimized.
…S/dataverse into 9851-datafile-payload-extension
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
scolapasta
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
sekmiller
approved these changes
Sep 27, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from In Review 🔎
to Ready for QA ⏩
Sep 27, 2023
kcondon
merged commit d4af8cf
into
9834-files-api-extension-file-counts
13 of 14 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While developing the Files tab UI for the SPA, we noticed that we need this API extension.
This PR includes the following new endpoints:
userFileAccessRequested (/api/access/datafile/{id}/userFileAccessRequested): Returns true or false depending on whether or not the calling user has requested access to a particular file.
hasBeenDeleted (/api/files/{id}/hasBeenDeleted): Know if a particular file that existed in a previous version of the dataset no longer exists in the latest version.
In addition, the DataFile API payload has been extended to include the following fields:
tabularData: Boolean field to know if the DataFile is of tabular type
fileAccessRequest: Boolean field to know if the file access requests are enabled on the Dataset (DataFile owner)
Which issue(s) this PR closes:
Suggestions on how to test this:
Test new API endpoints with curl calls:
curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER_URL/api/files/$ID/hasBeenDeleted"curl -H "X-Dataverse-key:$API_TOKEN" -X GET "$SERVER/api/access/datafile/{id}/userFileAccessRequested"Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes