Fix the issues with the permissions of the Docker scripts on Windows #9906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s reported on the issue #9904
pdurbin
changed the title
|
@jp-tosca thanks for the pull request! I added it to the agenda of Thursday's Containerization Working Group meeting: https://ct.gdcc.io |
|
Just noting that @poikilotherm gave some feedback here: https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/configbaker.20setup-all.2Esh.20perms/near/390731630 |
jp-tosca
changed the title
… 2023-09-21. Deleting the duplicated chmod and moving the bootstrap script copy to be executed before the chmod.
pdurbin
added
the
Component: Containers
pdurbin
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
poikilotherm
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Looks good to me, thx for the PR @jp-tosca !
(Layers are not in perfect order, but the drawbacks are negligible.)
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for Review ⏩
to Ready for QA ⏩
Oct 10, 2023
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When starting the containers on Windows configbaker-1 is able to connect to the DV-API and retrieve the version at "dataverse:8080/api/info/version" but when it tries to run the init.sh script it shows the following error:
"/scripts/bootstrap/dev/init.sh: line 10: /scripts/bootstrap/base/setup-all.sh: Permission denied"
Which issue(s) this PR closes:
Special notes for your reviewer:
The first solution was to add the chmod to the init.sh script, this also works but I consider this being a better solution since:
There is a line that set up permissions for scripts before this, but I didn't want to modify or move it since it is not clear that these permissions are necessary before the point the scripts are copied to ${SCRIPT_DIR}/bootstrap/base/. I left this code intact and added RUN chmod +x ${BOOTSTRAP_DIR}//.sh after the scripts were copied into the base folder.
Suggestions on how to test this:
Download the original version on windows (tested and working on windows 10).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A